Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angelscript] fix build dependency error #31711

Merged
merged 4 commits into from
May 31, 2023

Conversation

JonLiu1993
Copy link
Member

Fixes #31697

Fix error:

CMake Error at vcpkg/installed/x64-linux/share/angelscript/AngelscriptTargets.cmake:60 (set_target_properties):
  The link interface of target "Angelscript::angelscript" contains:

    Threads::Threads

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Tested usage successfully by angelscript:x64-windows and angelscript:x64-linux:

angelscript provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(Angelscript CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Angelscript::angelscript)
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 30, 2023
@JonLiu1993 JonLiu1993 marked this pull request as ready for review May 31, 2023 01:45
@JonLiu1993 JonLiu1993 requested a review from Adela0814 May 31, 2023 01:45
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label May 31, 2023
@dan-shaw dan-shaw merged commit 7aed178 into microsoft:master May 31, 2023
@JonLiu1993 JonLiu1993 deleted the dev/Jon/angelscript branch June 1, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[angelscript] build failure
3 participants